tapd: add itest for grouped asset channel funding #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
group-key-support
branch
2 times, most recently
from
bf764ca to
3c5f6cb
Compare
guggero
force-pushed
the
group-key-support
branch
from
3c5f6cb to
4c38293
Compare
guggero
force-pushed
the
group-key-support
branch
2 times, most recently
from
84bf0f8 to
d30865e
Compare
guggero
force-pushed
the
group-key-support
branch
from
d30865e to
103e485
Compare
|
Updated |
|
@GeorgeTsagk: review reminder |
guggero
force-pushed
the
group-key-support
branch
from
103e485 to
e159f66
Compare
guggero
force-pushed
the
group-key-support
branch
from
684cb4e to
b14f20b
Compare
|
Ready for review, @ffranr and @GeorgeTsagk. |
guggero
force-pushed
the
group-key-support
branch
from
b14f20b to
85ae741
Compare
We remove the Zane node from all tests where its only role was being the universe server. Starting a node takes multiple seconds, so if we can spin up fewer nodes, we can save some time. And functionality wise Charlie can easily be the universe, we just need to define its port upfront so we can configure it to be its own proof courier.
1 task
guggero
force-pushed
the
group-key-support
branch
from
85ae741 to
dedf12c
Compare
guggero
force-pushed
the
group-key-support
branch
2 times, most recently
from
949259f to
2ce063a
Compare
This commit prepares some of the helper functions to be able to handle channels that have multiple asset pieces in them.
guggero
force-pushed
the
group-key-support
branch
from
2ce063a to
23f300d
Compare
GeorgeTsagk
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
LGTM!
Non-blocking: Since the group keys on taprpc are already merged, we could enhance testCustomChannelsLiquidityEdgeCasesCore with an extra option similar to groupMode, which would control whether we open single asset ID or group funded channels. This way we could incorporate low-hanging coverage for this PR. Not sure what the diff for that would be, could def be a follow-up PR.
| // Test case 2: Send a few direct keysend payment from Erin to Fabia. | ||
| // ------------ | ||
| for i := 0; i < numSends; i++ { | ||
| // TODO(guggero): Actually specify group key here instead of |
There was a problem hiding this comment.
can actually use withGroupKey now
| github.com/lightninglabs/loop/looprpc v1.0.4-0.20250306160707-1091a628755c | ||
| github.com/lightninglabs/loop/swapserverrpc v1.0.13-0.20250306160707-1091a628755c | ||
| github.com/lightninglabs/lndclient v0.19.0-4 | ||
| github.com/lightninglabs/loop v0.31.0-beta.0.20250425065236-7e81916829d9 |
There was a problem hiding this comment.
this commit message only mentions tapd, while we also indirectly bump other core repos like lnd/loop/lndclient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/taproot-assets#1478.